-
Notifications
You must be signed in to change notification settings - Fork 471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce central crate version management #1908
Introduce central crate version management #1908
Conversation
2b2d87b
to
6727a61
Compare
I think the Rust MSRV has been the reason we haven't adopted this yet. Do you know what Rust version this requires? |
Yes, Maybe you are right. It seems require version 1.64 |
6727a61
to
d932185
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes look good to me. I think we should come up with some policy on features flags though, we have them in both the root as well as the direct dependencies. I wonder if we should always only specify them in the target crate?
FYI, this bumps MSRV to 1.64, this was discussed in the discord channel and approved by @djc there. |
436d4c3
to
5319d48
Compare
I have updated to remove all feature flags from workspace denpendencies. If you have time, Please review this again. @bluejekyll @djc |
Yeah, I think I like the features better on the target crate. That makes a lot more sense to me personally since we enable and disable features for different reasons in different crates. Thanks for making that change. |
5fc3cab
to
d018ba8
Compare
I'm going to merge, thanks for the PR! |
With this commit, we can manage versions of all crates in one place.
https://doc.rust-lang.org/cargo/reference/workspaces.html#the-dependencies-table