Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clicking "Show more" on the discussion page should not append ?lookback= to the URL repeatedly #34

Closed
raykyri opened this issue Apr 24, 2020 · 2 comments
Closed

Clicking "Show more" on the discussion page should not append ?lookback= to the URL repeatedly #34

raykyri opened this issue Apr 24, 2020 · 2 comments
Labels
bug Something isn't working

Comments

@raykyri
Copy link
Collaborator

raykyri commented Apr 24, 2020 •
edited
Loading

Currently it naively appends to the URL resulting in this:

image

We can remove the lookback param altogether (both writing it to the URL, and anywhere we read it from the URL.)
@raykyri raykyri changed the title Clicking "Show more" on the discussion page appends ?lookback= to the URL repeatedly Clicking "Show more" on the discussion page should not append ?lookback= to the URL repeatedly Apr 24, 2020
@dillchen dillchen added bug Something isn't working can be reassigned labels Apr 28, 2020
@gdjohnson
Copy link
Contributor

Will this be rendered obsolete given the infinite scroll feature?

@raykyri
Copy link
Collaborator Author

raykyri commented Apr 29, 2020

Seems so, we can deprecate this in favor of the infinite scroll task.

@raykyri raykyri closed this as completed Apr 29, 2020
jnaviask pushed a commit that referenced this issue Jul 15, 2022
@drewstone
Merge pull request #34 from hicommonwealth/jake.councillor-validator-…
9258619 
…events

Add validator election event and enrich council with members.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@raykyri @dillchen @gdjohnson