Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Members page loading should be blocked until all member profiles have loaded #44

Closed
raykyri opened this issue Apr 24, 2020 · 0 comments
Closed
Assignees

Comments

@raykyri
Copy link
Collaborator

raykyri commented Apr 24, 2020

When loading the members page, all the User components load asynchronously, which causes the page to flash as they load. We should prevent this flash by prefetching the User profiles, and showing a loading spinner when that happens.

Check out view_proposal.ts to see the technique we use to block loading that page until all authors/commenters' profiles are loaded.

This will be important later on as we expand this page to include more profile data, b/c the flashing will be much more annoying when it's full cards flashing

@raykyri raykyri closed this as completed Aug 20, 2020
jnaviask pushed a commit that referenced this issue Jul 15, 2022
…or-archival-mode

Revert "Enricher fixes for archival mode"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants