Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Community Switcher Account Change Bug #190

Merged
merged 2 commits into from
May 14, 2020

Conversation

zakhap
Copy link
Collaborator

@zakhap zakhap commented May 7, 2020

Description

Before: If you had two roles in the same community/chain, and you tried to switch accounts using the CommunitySwitcher in the sidebar, the active account would stay the same.
Now: The active account switches according to the Role associated with the community switch button in the sidebar.

Motivation and Context

Users should have a seamless experience switching between accounts, regardless of community, on Commonwealth.

How Has This Been Tested?

  • I connected multiple addresses to the Edgeware Chain Community (member roles) as well as to the Internal Offchain Community.
  • I then toggled between them in the sidebar, making sure the activeAddress was changing accordingly.

Clubhouse tickets/Github issues (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • My change should be included in the release notes.
  • I have updated the documentation accordingly.
  • I have linted the code locally prior to submission.

@zakhap zakhap self-assigned this May 7, 2020
@zakhap zakhap requested a review from dillchen May 7, 2020 14:08
@zakhap zakhap requested a review from drewstone May 11, 2020 17:27
@drewstone drewstone merged commit 012edb7 into raymond.construct May 14, 2020
@drewstone drewstone deleted the zak.community-switch-bug branch May 14, 2020 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants