Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix count and remove dispatch queue proposals from page. #25

Merged
merged 1 commit into from
Apr 22, 2020

Conversation

jnaviask
Copy link
Collaborator

Description

Currently, on Edgeware, we do not display proposals in the dispatch queue, although we do on Kusama. However, we count them both in the Header.

This patch removes dispatch queued proposals from the header count, and unifies the function of Kusama and Edgeware by simply not displaying proposals in the dispatch queue.

We may want to add a separate dispatch queue display, however, as the dispatch queue contents are useful for users to know.

How Has This Been Tested?

Ran it, made a proposal, checked the count and page.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • My change should be included in the release notes.
  • I have updated the documentation accordingly.
  • I have linted the code locally prior to submission.

@drewstone
Copy link
Contributor

Why don't we add the proposals from the dispatch queue in a PR instead of removing them?

@jnaviask
Copy link
Collaborator Author

Why don't we add the proposals from the dispatch queue in a PR instead of removing them?

They only show up on Kusama as of right now, and this was supposed to be a quick fix to bring the behavior of both chains in line. We can and should add the dispatch queue, but that would require designing some new UX, more than a quick fix.

@drewstone drewstone merged commit 50fbb63 into master Apr 22, 2020
@drewstone drewstone deleted the jake.fix-passed-proposal-display branch April 22, 2020 16:50
jnaviask pushed a commit that referenced this pull request Jul 15, 2022
Adds union type of all supported chains.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants