Implement session authentication (removing uuid from url) #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
December 10, 2023 09:49
- filling the username and password (password saved in database as plaintext)
because we send username and password with base64 encoding, so we're not limited to assci
THEN we check session cookies
chg: g.user and g.admin to g.account
- seperate storing account id in session
hiddify-com
reviewed
Dec 30, 2023
|
|
||
|
|
||
| @event.listens_for(AdminUser, "before_insert") | ||
| def before_insert(mapper, connection, target): |
There was a problem hiding this comment.
ببریم توی baseaccount
| @@ -171,6 +174,16 @@ def bulk_register_admins(users=[], commit=True): | |||
|
|
|||
|
|
|||
| def current_admin_or_owner(): | |||
There was a problem hiding this comment.
میدونم خودم نوشتم ولی چرا اخه؟ریسک امنیتی ایجاد میکنه
|
|
||
|
|
||
|
|
||
| def has_permission(admin) -> bool: |
There was a problem hiding this comment.
خیلی پرمیژن ها قاطی پاتی شده
| else: | ||
| values['proxy_path'] = hconfig(ConfigEnum.proxy_path_admin) | ||
|
|
||
| if hiddify.is_api_v1_call(endpoint=endpoint) and 'admin_uuid' not in values: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.