Merge pull request #103 from jtyr/jtyr-recursive

Support recursive without argument
hidetatz · Dec 31, 2022 · 2f8d86e · 2f8d86e
2 parents ffe7415 + 1d787ce
commit 2f8d86e
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/kubectl/subcommand.go b/kubectl/subcommand.go
@@ -191,7 +191,7 @@ func CollectCommandlineOptions(args []string, info *SubcommandInfo) {
 			info.NoHeader = true
 		} else if args[i] == "-w" || args[i] == "--watch" {
 			info.Watch = true
-		} else if args[i] == "--recursive=true" {
+		} else if args[i] == "--recursive=true" || args[i] == "--recursive" {
 			info.Recursive = true
 		} else if args[i] == "-h" || args[i] == "--help" {
 			info.Help = true

diff --git a/kubectl/subcommand_test.go b/kubectl/subcommand_test.go
@@ -51,8 +51,7 @@ func TestInspectSubcommandInfo(t *testing.T) {
 
 		{"explain pod", &SubcommandInfo{Subcommand: Explain}, true},
 		{"explain pod --recursive=true", &SubcommandInfo{Subcommand: Explain, Recursive: true}, true},
-		// "--recursive true" is not acceptable by kubectl explain
-		{"explain pod --recursive true", &SubcommandInfo{Subcommand: Explain}, true},
+		{"explain pod --recursive", &SubcommandInfo{Subcommand: Explain, Recursive: true}, true},
 
 		{"version", &SubcommandInfo{Subcommand: Version}, true},
 		{"version --client", &SubcommandInfo{Subcommand: Version}, true},