This repository has been archived by the owner on Jul 30, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
Handle panic in Print. When
recover()
, uncolored output will be shown.WHY
When "kubecolor plugin_name version" or so on is specified, is should not colorize because kubecolor does not support plugins.
However, right now, kubecolor thinks "plugin_name" is a command-line option and the subcommand is "version" (= "kubectl version"). Then, VersionPrinter is called but it fail to parse then panic.
Ideally, it should understand if the given command is running plugin or not, but it seems like it is likely impossible.
This is just a workaround to "accept" mis parsing and panic.
Related issue (if exists)
#68