Use a buffered inputstream to read from the socket #795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the read from the socket is not buffered what can slow down reading bytes by byte. This wraps the input stream in the PacketReader in a BufferedInputStream to read larger chuncks of data to improve performance.
|
@hierynomus I'm not sure if there are any performance tests but while profiling my application I noticed that most time is spend on reading from the socket so I would assume this can increase performance here. |
Signed-off-by: Jeroen van Erp <jeroen@hierynomus.com>
hierynomus
approved these changes
Sep 11, 2023
|
Thanks, I've fixed the styling issue detected, and approved and merged the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the read from the socket is not buffered what can slow down reading bytes by byte.
This wraps the input stream in the PacketReader in a BufferedInputStream to read larger chuncks of data to improve performance.