Avoid setting SFTP rename flags below version 5 (#751) (#754)

Fixes #750 Fixes #751 Co-authored-by: Jeroen van Erp <jeroen@hierynomus.com>
hierynomus · Dec 22, 2021 · ce0a7d5 · ce0a7d5
1 parent ced27fc
commit ce0a7d5
Showing 1 changed file with 9 additions and 6 deletions.
diff --git a/src/main/java/net/schmizz/sshj/sftp/SFTPEngine.java b/src/main/java/net/schmizz/sshj/sftp/SFTPEngine.java
@@ -235,14 +235,17 @@ public void rename(String oldPath, String newPath, Set<RenameFlags> flags)
         if (operativeVersion < 1)
             throw new SFTPException("RENAME is not supported in SFTPv" + operativeVersion);
 
-        long renameFlagMask = 0L;
-        for (RenameFlags flag : flags) {
-            renameFlagMask = renameFlagMask | flag.longValue();
+        final Request request = newRequest(PacketType.RENAME).putString(oldPath, sub.getRemoteCharset()).putString(newPath, sub.getRemoteCharset());
+        // SFTP Version 5 introduced rename flags according to Section 6.5 of the specification
+        if (operativeVersion >= 5) {
+            long renameFlagMask = 0L;
+            for (RenameFlags flag : flags) {
+                renameFlagMask = renameFlagMask | flag.longValue();
+            }
+            request.putUInt32(renameFlagMask);
         }
 
-        doRequest(
-                newRequest(PacketType.RENAME).putString(oldPath, sub.getRemoteCharset()).putString(newPath, sub.getRemoteCharset()).putUInt32(renameFlagMask)
-        ).ensureStatusPacketIsOK();
+        doRequest(request).ensureStatusPacketIsOK();
     }
 
     public String canonicalize(String path)