-
Notifications
You must be signed in to change notification settings - Fork 599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OSGI dependencies are broken #255
Comments
As I'm not an OSGI whiz, what would be the best solution for this? Isn't this something that needs to be fixed in the |
src/main/java/net/schmizz/sshj/common/KeyType.java imports the package and uses types from it. So it needs to be fixed in the net.i2p.crypto.eddsa pom. |
Thank you for the quick response! |
Please publish a new release containing this fix. Thank You! |
Done, version 0.18.0 is downloadable from Maven. |
Unfortunately it's still broken. The build.gradle file also needs to be corrected. I've created a pull request. |
I am currently working on a project that tests how sshj behaves in an OSGI environment.
I fixed all of the above by changing
But I am still working on my testing project... |
Let me know once you've finished testing. I'll reopen this ticket until then. |
Test project is here: https://github.com/15knots/sshj.osgi.tests |
I changed the testing project to work with development versions of sshj, too. It now proves that the |
@15knots is there any specific reason why you are using |
@adagios Thanks, I was wondering the same, but having not enough experience with OSGI bundles I accepted the change. If you have a better proposition I'm all ears. |
@hierynomus I think I got it running with only
|
Nope, that is related to not running a JVM with the unlimited crypto extensions :) |
I've created a pull request with my solution. @15knots wan't to test it? With regards to exporting |
@adagios, @hierynomus: I used |
With d1dff55, test no longer fail. Thanks! |
Does it run with sshj#295?
Op 12 jan. 2017 8:05 p.m. schreef "15knots" <notifications@github.com>:
… With d1dff55
<d1dff55>,
test no longer fail.
mvn -Dsshj.version=0.19.2-dev.6.uncommitted+d1dff55 verify runs
successfully.
Thanks!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#255 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAHLoyjSxaUJzSePV5EwylBbxSqI5WrNks5rRnlxgaJpZM4JORMd>
.
|
@hierynomus Pls help me to check out the commit of the PR for #295. |
Sorry for the delay, github``s web UI confused me first, then I realized that I have to switch to adagios´ repo to get that commit:-) Commit 66d4b34 for #295 fails as follows:
Unfortunately, |
I had a look, and It's failing because it can't find the class I took a look at the equinox config at |
@hierynomus I think that this is done. Can you share when are you thinking of releasing a new version? I would really like to switch to an official version :) |
I'll merge #295 in in a moment. It might be cool if we could somehow integrate the osgi test into the build so that it is verified to not break. Don't know how feasible that is, and whether there are plugins for that for Gradle? |
#295 has been merged. |
I'm encountering the same error now at runtime in OSGi. It might be possible to avoid the problem here using (The right fix I think per the second and third messages would be in A workaround -- in case someone else comes across this -- is to wrap the dependencies to explicitly export and import
|
Thank you! I was considering having to rebuild both libraries to correct the problem. TIL you can wrap the bundle in that manner - excellent. |
The manifest header declares a dependency to package
net.i2p.crypto.eddsa.math
, but bundlenet.i2p.crypto.eddsa
does not export that package. (The pom of net.i2p.crypto.eddsa explicitly excludes the package from the exported package list.)This results in a tycho error when building:
Missing requirement: com.hierynomus.sshj 0.17.2 requires 'package net.i2p.crypto.eddsa.math 0.0.0' but it could not be found
The text was updated successfully, but these errors were encountered: