-
Notifications
You must be signed in to change notification settings - Fork 599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Timeout not honored on hung connection #466
Comments
I think this is due to |
Feel free to send a pr!
Op di 13 nov. 2018 19:56 schreef Ben Manes <notifications@github.com:
… I think this is due to awaitExpansion not having a timeout to fail the
operation, as it waits indefinitely. Can this be patched to fail instead of
block forever?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#466 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAHLo7DWkYSH-EOQycU-iQowKy4cE-jgks5uuxXcgaJpZM4Ya8Y9>
.
|
Do you consider If this can be pushed it will save me from moving to Commons VFS, so happy to send the PR :) |
Window is not a class you typically interact with in using sshj, so no, not an API ;) |
When the remove window size is expanded, a condition is waited on until the remote server acknowledges and completes the action. If the server does not respond, e.g. due to a connectivity issue, then this blocks the client indefinitely. Instead the client waits up to the connection's timeout (500 min default) and fails. This allows users to set a reasonable timeout, fail their operations, and retry accordingly.
When the remove window size is expanded, a condition is waited on until the remote server acknowledges and completes the action. If the server does not respond, e.g. due to a connectivity issue, then this blocks the client indefinitely. Instead the client waits up to the connection's timeout (500 min default) and fails. This allows users to set a reasonable timeout, fail their operations, and retry accordingly.
Despite setting timeouts where possible, I am seeing hung connections with a customer's sftp server. Is there a way to have this timeout?
The text was updated successfully, but these errors were encountered: