-
Notifications
You must be signed in to change notification settings - Fork 600
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KeepAlive threads don't die if authPassword fails #506
Comments
The switch seems to have resolved the hang thread on that occasion, but it now seems that there are other times when the keep-alive (and even the reader thread) are kept well after they should have stopped. Still trying to gather more information / reduce the problem. |
exceptionfactory
added a commit
to exceptionfactory/sshj
that referenced
this issue
Dec 21, 2021
…ierynomus#506) - Changed KeepAlive.setKeepAliveInterval() to avoid starting Thread - Updated SSHClient.onConnect() to start KeepAlive Thread when enabled - Updated SSHClient.disconnect() to interrupt KeepAlive Thread - Updated KeepAliveThreadTerminationTest to verify state of KeepAlive Thread
hierynomus
added a commit
that referenced
this issue
Dec 22, 2021
) (#752) - Changed KeepAlive.setKeepAliveInterval() to avoid starting Thread - Updated SSHClient.onConnect() to start KeepAlive Thread when enabled - Updated SSHClient.disconnect() to interrupt KeepAlive Thread - Updated KeepAliveThreadTerminationTest to verify state of KeepAlive Thread Co-authored-by: Jeroen van Erp <jeroen@hierynomus.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When there's an EOF during
authPassword()
, the KeepAlive thread is not stopped, and because the transport is not running, just keeps sleeping on an infinite loop.An example of the logs I'm seeing:
I'm trying to work around it by switching the order of autoPassword and turning the KeepAlive on, from the order given in the KeepAlive example:
to
will update when I find out the results.
The text was updated successfully, but these errors were encountered: