-
Notifications
You must be signed in to change notification settings - Fork 599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compatibility features #269
Conversation
…AF provider. 1) Added boolean Channel.isEOF() method, for checking whether the server has sent EOF. 2) Added SFTP response constants to the Response enumeration 3) Spelling correction for the SYMLINK FileMode enum constant
Hi David, unfortunately Java6 compatibility is a no-go, as per #234, the ed-25519 library we depend on is java7 only. |
Interesting. I actually compiled the ed25519-java project using Java 6, made a Java 6 build of sshj and it worked fine. (We don't allow build frameworks to pull down dependencies for production builds, we compile everything from source). |
Hi David, Unfortunately the ed25519-java project is released only with a Java7 build. So I also only support java7. Also because Java6 is EOL, and Java7 is also officially EOL-ed by Oracle, see: http://www.oracle.com/technetwork/java/eol-135779.html So for me, adding back in Java6 support is a step backwards, also because my CI builds run with java7+, and do not test for java6 compatibility anymore. So there is absolutely no guarantee that these changes will be kept in. |
I know, they're dinosaurs, but I think we have customers who are still using it. I see it more on AIX and old versions of Linux using OpenJDK (not Oracle's VM). How about this, what if I take responsibility for any Java 6 compatibility work? Feel free to break Java 6 compatibility and if it bothers me, I'll fix it? You won't have to worry about it, and the project can officially still require Java 7. (Obviously though, you'll have to leave me the option of eventually giving up on trying to maintain compatibility.) |
Hi David, I had another quick look at the code. Essentially the Looking through the code. I just use the What I would propose is that we can add back Java6 compatibility by including the Sound like a plan? |
Sounds awesome! Thanks! |
@@ -394,6 +401,7 @@ private void gotEOF() | |||
/** Called when EOF has been received. Subclasses can override but must call super. */ | |||
protected void eofInputStreams() { | |||
in.eof(); | |||
eof = true; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Somehow your indenting is off sometimes ;)
Can you merge in master so that the checks are green ;) |
I'm sorry man. I actually write code in vi (speaking of dinosaurs), and I normally use 1 tab for 8 spaces. |
I think the right dinosaur settings are:
😉 |
Sorry clicked wrong button there... If you can get the branch up-to-date then we're good to go! |
I think I just did. :) |
These are the remaining changes I had to add to sshj for compatibility with Joval's jSAF provider code. They're all relatively minor so I hope it makes sense to group them together: