-
Notifications
You must be signed in to change notification settings - Fork 599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ecdsa sha2++ #336
Ecdsa sha2++ #336
Conversation
Hi, Thanks for the PR! :) Great work. Could you add some tests with the different keytypes, especially for the bug found in the ASN.1 encoding? THen it is complete and ready to be merged. |
Sure, just a couple of questions :)
|
Yes, please add at least tests for the failures you found, that would prevent regressions. There are some tests that connect to an Apache Mina SSH server, which is booted up in memory. But I would also welcome some (Dockerized) OpenSSH tests, that would be awesome. |
I've added the unit-tests for the cases. |
Looks great, thanks! I'll do some tests tomorrow and merge it afterwards. Looking forward to your next pull request. Sent from my Samsung SM-G950F using FastHub |
Hey there!
I've added support for ecdsa-sha2-nistp384 and ecdsa-sha2-nistp521 in this PR. The *521 one also uncovered a problem in the way you've been asn1-encoding stuff, so I've switched that from "manual" to a more "official" way.