Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parameter to limit read ahead to maximum length. Allows to use mu… #724

Merged
merged 2 commits into from
Dec 23, 2021

Conversation

dkocher
Copy link
Contributor

@dkocher dkocher commented Sep 24, 2021

…ltiple concurrent threads reading from the same file with an offset without reading too much ahead for a single segment.

@dkocher dkocher requested a review from hierynomus as a code owner September 24, 2021 09:05
@hierynomus
Copy link
Owner

@dkocher Is it possible to add a test for this?

@dkocher dkocher force-pushed the feature/readahead-limit branch 2 times, most recently from 0f8da93 to 611581d Compare December 23, 2021 19:33
dkocher and others added 2 commits December 23, 2021 20:34
…ltiple concurrent threads reading from the same file with an offset without reading too much ahead for a single segment.
Signed-off-by: David Kocher <dkocher@iterate.ch>
@dkocher dkocher force-pushed the feature/readahead-limit branch from 611581d to 93846ea Compare December 23, 2021 19:34
@dkocher
Copy link
Contributor Author

dkocher commented Dec 23, 2021

@hierynomus Test has been added.

@hierynomus hierynomus merged commit 8cf63a9 into hierynomus:master Dec 23, 2021
@hierynomus
Copy link
Owner

Thanks, merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants