Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TimeoutException message improved #835

Merged
merged 1 commit into from
Jan 6, 2023

Conversation

jpstotz
Copy link
Contributor

@jpstotz jpstotz commented Jan 6, 2023

A minor improvement to include the actual timeout value into the exception message.
This can get handy in complex scenarios where it is not obvious what timeout is configured for the command that had failed.

@jpstotz jpstotz requested a review from hierynomus as a code owner January 6, 2023 08:49
@codecov-commenter
Copy link

codecov-commenter commented Jan 6, 2023

Codecov Report

Merging #835 (1f05d33) into master (6e7fb96) will increase coverage by 0.04%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##             master     #835      +/-   ##
============================================
+ Coverage     64.84%   64.89%   +0.04%     
- Complexity     1467     1468       +1     
============================================
  Files           210      210              
  Lines          8537     8537              
  Branches        781      781              
============================================
+ Hits           5536     5540       +4     
+ Misses         2592     2589       -3     
+ Partials        409      408       -1     
Impacted Files Coverage Δ
src/main/java/net/schmizz/concurrent/Promise.java 80.30% <0.00%> (ø)
...net/schmizz/sshj/transport/TransportException.java 44.44% <0.00%> (-11.12%) ⬇️
...ain/java/net/schmizz/sshj/common/SSHException.java 67.74% <0.00%> (-6.46%) ⬇️
...rc/main/java/net/schmizz/sshj/sftp/RemoteFile.java 56.55% <0.00%> (+0.68%) ⬆️
...zz/sshj/connection/channel/ChannelInputStream.java 77.27% <0.00%> (+1.51%) ⬆️
...java/net/schmizz/sshj/transport/TransportImpl.java 66.94% <0.00%> (+1.65%) ⬆️
.../main/java/net/schmizz/sshj/sftp/PacketReader.java 95.74% <0.00%> (+4.25%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@hierynomus hierynomus merged commit dcfa183 into hierynomus:master Jan 6, 2023
@hierynomus
Copy link
Owner

Thanks!

@jpstotz jpstotz deleted the TimeoutException branch January 6, 2023 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants