-
Notifications
You must be signed in to change notification settings - Fork 599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace custom Base64 with java.util.Base64 #879
Conversation
Sonatype Lift is retiringSonatype Lift will be retiring on Sep 12, 2023, with its analysis stopping on Aug 12, 2023. We understand that this news may come as a disappointment, and Sonatype is committed to helping you transition off it seamlessly. If you’d like to retain your data, please export your issues from the web console. |
Codecov Report
@@ Coverage Diff @@
## master #879 +/- ##
============================================
+ Coverage 65.34% 68.06% +2.72%
+ Complexity 1441 1399 -42
============================================
Files 209 208 -1
Lines 8060 7463 -597
Branches 746 637 -109
============================================
- Hits 5267 5080 -187
+ Misses 2396 2038 -358
+ Partials 397 345 -52
|
Thanks for another pull request! Looking good and merged. |
* Bump com.hierynomus:sshj from 0.32.0 to 0.36.0 in /prime-router Bumps [com.hierynomus:sshj](https://github.com/hierynomus/sshj) from 0.32.0 to 0.36.0. - [Commits](hierynomus/sshj@v0.32.0...v0.36.0) --- updated-dependencies: - dependency-name: com.hierynomus:sshj dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * update for hierynomus/sshj#879 * Modified SftpTransport to be able to handle SSHRSA as older version * Modified SftpTransport to be able to handle SSHRSA as older version --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Stephen Nesman <94193373+snesm@users.noreply.github.com> Co-authored-by: Ott Sathngam <ott.sathngam@gmail.com>
This pull request replaces the custom
net.schmizz.sshj.common.Base64
class with the standardjava.util.Base64
implementation.Following the changes in #874 to make Java 8 the minimum required version, maintaining a standalone Base64 implementation is no longer required.
Although the Base64 class has remained stable, it does not have standalone unit tests. Switching to
java.util.Base64
provides the same functionality and all tests pass using the standard implementation.