Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce Kotlin lint (detekt) #181

Closed
hieuwu opened this issue Oct 1, 2023 · 5 comments
Closed

Introduce Kotlin lint (detekt) #181

hieuwu opened this issue Oct 1, 2023 · 5 comments
Assignees
@Kardelio
Labels
hacktoberfest

Comments

@hieuwu
Copy link
Owner

hieuwu commented Oct 1, 2023

Is your feature request related to a problem? Please describe.
To make the code base to be consistent
@Kardelio
Copy link
Contributor

Kardelio commented Oct 2, 2023

Ooooo can i grab this issue?

@hieuwu
Copy link
Owner Author

hieuwu commented Oct 2, 2023

Ooooo can i grab this issue?

Sure Kar. Let’s do it

@Kardelio
Copy link
Contributor

Kardelio commented Oct 2, 2023

Awesome! thank you!
So just to be clear its about bring detekt in as a linter.
Is there anything more? Like implement into CI/CD or something more?

@hieuwu
Copy link
Owner Author

hieuwu commented Oct 2, 2023

Awesome! thank you! So just to be clear its about bring detekt in as a linter. Is there anything more? Like implement into CI/CD or something more?

Yeah adding it and being able to execute the command to see analyze is good eough. It would be nice if you can implement it into the GitHub action before build step. Many thanks Kar

@Kardelio Kardelio mentioned this issue Oct 5, 2023
Merged
@hieuwu
Copy link
Owner Author

hieuwu commented Oct 5, 2023

Close as completed in #191

@hieuwu hieuwu closed this as completed Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Kardelio Kardelio

Labels
hacktoberfest
Projects
Groceries Store
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Kardelio @hieuwu