Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added detekt into the project #191

Merged
merged 1 commit into from
Oct 5, 2023
Merged

Added detekt into the project #191

merged 1 commit into from
Oct 5, 2023

Conversation

Kardelio
Copy link
Contributor

@Kardelio Kardelio commented Oct 5, 2023

#181

Added detekt into the project.
Added a github action step to check Detekt as part of the build.

NOTE

At the moment detekt fails due to many issues, so the builds will all fail so we need to either disable the detekt step, capture the baseline for detekt to be able to ignore certain things or fix all the detekt issues...

@hieuwu hieuwu changed the title Issue #181 Added detekt into the project Oct 5, 2023
@hieuwu hieuwu self-requested a review October 5, 2023 09:57
@hieuwu
Copy link
Owner

hieuwu commented Oct 5, 2023

#181

Added detekt into the project. Added a github action step to check Detekt as part of the build.

NOTE

At the moment detekt fails due to many issues, so the builds will all fail so we need to either disable the detekt step, capture the baseline for detekt to be able to ignore certain things or fix all the detekt issues...

Great work, Kar! Thank you so much for pointing out the fail of detekt. I think just make sure it runs locally well and that's fine. I'll temporarily disable detekt for now and resolve it locally. Will enable it later in the workflow

local.properties Outdated Show resolved Hide resolved
@Kardelio
Copy link
Contributor Author

Kardelio commented Oct 5, 2023

@hieuwu awesome!
Ok i forced pushed and disabled detekt step and also remove the sdk change that was falsely there :) hope this is ok

@hieuwu hieuwu merged commit d418163 into hieuwu:main Oct 5, 2023
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants