Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement decimal parser 🔢 #1

Merged
merged 8 commits into from
Feb 14, 2020
Merged

Implement decimal parser 🔢 #1

merged 8 commits into from
Feb 14, 2020

Conversation

kutyel
Copy link
Member

@kutyel kutyel commented Feb 12, 2020

Initial work related to higherkindness/mu-haskell#106.


⚠️ We first need to propose a PR to Data.Avro to make this really work!

Depends on haskell-works/avro#135 to be merged!

@kutyel kutyel requested a review from serras February 12, 2020 14:02
@serras
Copy link
Collaborator

serras commented Feb 12, 2020

I understand the spec differently. If ther are two numbers, the first one is precision.

@kutyel
Copy link
Member Author

kutyel commented Feb 12, 2020

Makes sense, thanks! 😉

@serras serras marked this pull request as ready for review February 14, 2020 14:21
@kutyel kutyel merged commit c8f7497 into master Feb 14, 2020
@kutyel kutyel deleted the decimal branch February 14, 2020 15:56
kutyel added a commit that referenced this pull request Jan 4, 2022
Co-authored-by: Alejandro Serrano <trupill@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants