Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove all usecase scaladoc tags, which crash sbt and prevent publishing #136

Merged
merged 1 commit into from
Nov 15, 2019

Conversation

andyscott
Copy link
Member

Removes @usecase scaladoc tags, which crash SBT during publish.

See scala/bug#11572 and sbt/sbt#4665 for some more context.

Copy link
Collaborator

@travisbrown travisbrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure it wouldn't be better just to disable docs for 2.13 for now, since presumably this will get fixed at some point? I think something like this should work:

publishArtifact in (Compile, packageDoc) := !scalaVersion.value.startsWith("2.13")

I guess you can also always just revert this, so it probably it doesn't matter much.

@andyscott
Copy link
Member Author

andyscott commented Nov 15, 2019

The problem pops up in 2.12 and 2.13 (although the first ticket linked indicates it's a 2.13 only problem). I'm not sure if it's problematic in 2.11.

@andyscott andyscott merged commit e0e095f into master Nov 15, 2019
@andyscott andyscott deleted the andyscott/remove-all-usecase-scaladoc-comments branch November 15, 2019 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants