Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RIP distributive law. Hello gather/scatter #37

Merged
merged 3 commits into from
Jul 19, 2018
Merged

Conversation

andyscott
Copy link
Member

@andyscott andyscott commented Jul 18, 2018

This is an attempt to try out the changes suggested in recursion-schemes/recursion-schemes#51

@andyscott andyscott force-pushed the rip-dist-law branch 2 times, most recently from da9cd8a to b961b87 Compare July 18, 2018 06:34
@codecov
Copy link

codecov bot commented Jul 18, 2018

Codecov Report

Merging #37 into master will decrease coverage by 3.35%.
The diff coverage is 60%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #37      +/-   ##
==========================================
- Coverage      82%   78.64%   -3.36%     
==========================================
  Files          17       20       +3     
  Lines         200      206       +6     
==========================================
- Hits          164      162       -2     
- Misses         36       44       +8
Impacted Files Coverage Δ
athema/src/main/scala/qq/athema/algebras.scala 69.56% <100%> (ø) ⬆️
modules/core/src/main/scala/qq/droste/gather.scala 100% <100%> (ø)
...s/core/src/main/scala/qq/droste/data/package.scala 66.66% <100%> (+3.03%) ⬆️
...odules/core/src/main/scala/qq/droste/scatter.scala 25% <25%> (ø)
modules/core/src/main/scala/qq/droste/zoo.scala 53.33% <53.33%> (ø)
modules/core/src/main/scala/qq/droste/scheme.scala 88.88% <66.66%> (+17.46%) ⬆️
modules/core/src/main/scala/qq/droste/dist.scala 0% <0%> (-100%) ⬇️
...s/core/src/main/scala/qq/droste/data/prelude.scala 45.45% <0%> (-36.37%) ⬇️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a0ffedf...b0aae7d. Read the comment docs.

@andyscott andyscott merged commit 887c471 into master Jul 19, 2018
@andyscott andyscott deleted the rip-dist-law branch July 19, 2018 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant