propagate specific target tags to run and run_shell actions as execut…

…ion_requirements

rules/common/private/utils.bzl

@@ -117,6 +117,18 @@ def safe_name(value):
 def _short_path(file):
     return file.short_path
 
+# This propagates specific tags as execution requirements to be passed to an action
+# A fix to bazelbuild/bazel that will make this no longer necessary is underway; we can remove this once that's released and we've obtained it
+PROPAGATABLE_TAGS = ["no-remote", "no-cache", "no-sandbox", "no-remote-exec", "no-remote-cache"]
+
+def resolve_execution_reqs(ctx, base_exec_reqs):
+    exec_reqs = {}
+    for tag in ctx.attr.tags:
+        if tag in PROPAGATABLE_TAGS:
+            exec_reqs.update({tag: "1"})
+    exec_reqs.update(base_exec_reqs)
+    return exec_reqs
+
 def action_singlejar(
         ctx,
         inputs,
@@ -151,7 +163,7 @@ def action_singlejar(
     ctx.actions.run(
         arguments = [args],
         executable = ctx.executable._singlejar,
-        execution_requirements = {"supports-workers": "1"},
+        execution_requirements = resolve_execution_reqs(ctx, {"supports-workers": "1"}),
         mnemonic = _SINGLE_JAR_MNEMONIC,
         inputs = all_inputs,
         outputs = [output],

rules/private/phases/phase_bootstrap_compile.bzl

@@ -2,6 +2,10 @@ load(
     "//rules/common:private/utils.bzl",
     _strip_margin = "strip_margin",
 )
+load(
+    "//rules/common:private/utils.bzl",
+    _resolve_execution_reqs = "resolve_execution_reqs",
+)
 
 #
 # PHASE: bootstrap compile
@@ -51,4 +55,5 @@ def phase_bootstrap_compile(ctx, g):
                 output_jar = g.classpaths.jar.path,
             ),
         ),
+        execution_requirements = _resolve_execution_reqs(ctx, {}),
     )

rules/private/phases/phase_coverage_jacoco.bzl

@@ -6,6 +6,10 @@ load(
     "@rules_scala_annex//rules/private:coverage_replacements_provider.bzl",
     _coverage_replacements_provider = "coverage_replacements_provider",
 )
+load(
+    "@rules_scala_annex//rules/common:private/utils.bzl",
+    _resolve_execution_reqs = "resolve_execution_reqs",
+)
 
 def phase_coverage_jacoco(ctx, g):
     if not ctx.configuration.coverage_enabled:
@@ -40,7 +44,7 @@ def phase_coverage_jacoco(ctx, g):
         outputs = [in_out_pair[1] for in_out_pair in in_out_pairs],
         executable = code_coverage_configuration.instrumentation_worker.files_to_run.executable,
         input_manifests = worker_input_manifests,
-        execution_requirements = {"supports-workers": "1"},
+        execution_requirements = _resolve_execution_reqs(ctx, {"supports-workers": "1"}),
         arguments = [args],
     )
 

rules/private/phases/phase_zinc_compile.bzl

@@ -7,6 +7,10 @@ load(
     _ZincConfiguration = "ZincConfiguration",
     _ZincInfo = "ZincInfo",
 )
+load(
+    "@rules_scala_annex//rules/common:private/utils.bzl",
+    _resolve_execution_reqs = "resolve_execution_reqs",
+)
 
 #
 # PHASE: compile
@@ -80,7 +84,7 @@ def phase_zinc_compile(ctx, g):
         outputs = outputs,
         executable = worker.files_to_run.executable,
         input_manifests = input_manifests,
-        execution_requirements = {"no-sandbox": "1", "supports-workers": "1"},
+        execution_requirements = _resolve_execution_reqs(ctx, {"no-sandbox": "1", "supports-workers": "1"}),
         arguments = [args],
     )
 

rules/private/phases/phase_zinc_depscheck.bzl

@@ -3,6 +3,10 @@ load(
     _DepsConfiguration = "DepsConfiguration",
     _LabeledJars = "LabeledJars",
 )
+load(
+    "@rules_scala_annex//rules/common:private/utils.bzl",
+    _resolve_execution_reqs = "resolve_execution_reqs",
+)
 
 #
 # PHASE: depscheck
@@ -39,7 +43,7 @@ def phase_zinc_depscheck(ctx, g):
             outputs = [deps_check],
             executable = deps_configuration.worker.files_to_run.executable,
             input_manifests = worker_input_manifests,
-            execution_requirements = {"supports-workers": "1"},
+            execution_requirements = _resolve_execution_reqs(ctx, {"supports-workers": "1"}),
             arguments = [deps_args],
         )
         deps_checks[name] = deps_check

rules/scala/private/doc.bzl

@@ -3,7 +3,14 @@ load(
     _ScalaConfiguration = "ScalaConfiguration",
     _ZincConfiguration = "ZincConfiguration",
 )
-load("//rules/common:private/utils.bzl", _collect = "collect")
+load(
+    "//rules/common:private/utils.bzl",
+    _collect = "collect",
+)
+load(
+    "//rules/common:private/utils.bzl",
+    _resolve_execution_reqs = "resolve_execution_reqs",
+)
 
 scaladoc_private_attributes = {
     "_runner": attr.label(
@@ -53,7 +60,7 @@ def scaladoc_implementation(ctx):
     ctx.actions.run(
         arguments = [args],
         executable = ctx.attr._runner.files_to_run.executable,
-        execution_requirements = {"supports-workers": "1"},
+        execution_requirements = _resolve_execution_reqs(ctx, {"supports-workers": "1"}),
         input_manifests = input_manifests,
         inputs = depset(
             src_jars + srcs + [zinc_configuration.compiler_bridge],

rules/scala_proto/private/core.bzl

@@ -2,6 +2,10 @@ load(
     "//rules/common:private/utils.bzl",
     _safe_name = "safe_name",
 )
+load(
+    "//rules/common:private/utils.bzl",
+    _resolve_execution_reqs = "resolve_execution_reqs",
+)
 
 scala_proto_library_private_attributes = {}
 
@@ -41,7 +45,7 @@ def scala_proto_library_implementation(ctx):
         outputs = [gendir],
         executable = compiler.compiler.files_to_run.executable,
         tools = compiler_inputs,
-        execution_requirements = {"supports-workers": supports_workers},
+        execution_requirements = _resolve_execution_reqs(ctx, {"supports-workers": supports_workers}),
         arguments = [args],
     )
 
@@ -52,4 +56,5 @@ def scala_proto_library_implementation(ctx):
         command = """$1 c $4 META-INF/= $(find -L $2 -type f | while read v; do echo ${v#"${2%$3}"}=$v; done)""",
         progress_message = "Bundling compiled Scala into srcjar",
         tools = [ctx.executable._zipper],
+        execution_requirements = _resolve_execution_reqs(ctx, {}),
     )

rules/scalafmt/private/test.bzl

@@ -1,3 +1,8 @@
+load(
+    "@rules_scala_annex//rules/common:private/utils.bzl",
+    _resolve_execution_reqs = "resolve_execution_reqs",
+)
+
 scala_format_attributes = {
     "config": attr.label(
         allow_single_file = [".conf"],
@@ -47,7 +52,7 @@ def build_format(ctx):
                 input_manifests = runner_manifests,
                 inputs = [ctx.file.config, src],
                 tools = runner_inputs,
-                execution_requirements = {"supports-workers": "1"},
+                execution_requirements = _resolve_execution_reqs(ctx, {"supports-workers": "1"}),
                 mnemonic = "ScalaFmt",
             )
             manifest_content.append("{} {}".format(src.short_path, file.short_path))
@@ -68,6 +73,7 @@ def format_runner(ctx, manifest, files):
             manifest.short_path,
             ctx.outputs.scalafmt_runner.path,
         ],
+        execution_requirements = _resolve_execution_reqs(ctx, {}),
     )
 
 def format_tester(ctx, manifest, files):
@@ -81,6 +87,7 @@ def format_tester(ctx, manifest, files):
             manifest.short_path,
             ctx.outputs.scalafmt_testrunner.path,
         ],
+        execution_requirements = _resolve_execution_reqs(ctx, {}),
     )
 
 def scala_format_test_implementation(ctx):

tests/tagging/BUILD

@@ -0,0 +1,32 @@
+load("@rules_scala_annex//rules:scala.bzl", "scala_binary", "scala_library", "scala_test")
+load(
+    "@rules_scala_annex//rules/common:private/utils.bzl",
+    _PROPAGATABLE_TAGS = "PROPAGATABLE_TAGS",
+)
+
+scala_binary(
+    name = "binary-all-propagatable",
+    srcs = ["A.scala"],
+    scala = "//scala:2_11",
+    tags = ["manual"] + _PROPAGATABLE_TAGS,
+)
+
+scala_library(
+    name = "library-no-propagatable",
+    srcs = ["A.scala"],
+    scala = "//scala:2_11",
+    tags = [
+        "manual",
+        "requires-network",
+    ],
+)
+
+scala_test(
+    name = "test-no-remote-only",
+    srcs = ["A.scala"],
+    scala = "//scala:2_11",
+    tags = [
+        "manual",
+        "no-remote",
+    ],
+)

tests/tagging/test

@@ -0,0 +1,25 @@
+#!/bin/bash -e
+. "$(dirname "$0")"/../common.sh
+
+IFS=$'\n'
+
+function check_execution_info {
+  target=$1
+  all_exec_info=$((bazel aquery $target) | egrep "ExecutionInfo")
+
+  for exec_info in $all_exec_info; do
+    for arg in $@; do
+      if [[ $arg == $1 || "$exec_info" =~ "$arg" ]]; then
+        continue
+      else
+        echo "Failed. $arg not found in tags"
+        exit 1
+      fi
+    done
+  done
+}
+
+check_execution_info "library-no-propagatable"
+check_execution_info "binary-all-propagatable" "no-remote" "no-cache" "no-sandbox" "no-remote-exec" "no-remote-cache"
+check_execution_info "test-no-remote-only" "no-remote"
+echo "SUCCESS"