-
Notifications
You must be signed in to change notification settings - Fork 28
Pass select tags from target to generated actions as execution requirements #187
Comments
I'm happy to take this issue sometime this week. |
tags
attribute to generated Actions
It appears that this will be taken care of upstream in the future: https://docs.google.com/document/d/1X2GtuuNT6UqYYOK5lJWQEdPjAgsbdB3nFjjmjso-XHo/edit?ts=5ca70ed0# I'll still open a PR with a fix for |
@SrodriguezO I've just created PR for Bazel yesterday ;) bazelbuild/bazel#8612 |
Ah woops, I totally missed that. Thanks @ishikhman! :) I'll leave this issue open though; I imagine the fix to |
Yes, it will be released somewhere in July. |
The
tags
attribute lets us tell Bazel to treat certain actions specially; for example, the "no-remote" tag will inform Bazel that an action should not be run remotely even if it otherwise would.Unfortunately, Bazel doesn't automatically propagate tags from a rule to the actions the rule generates. We need to explicitly do this propagation in our rule implementations.
See: bazelbuild/bazel#7766
The text was updated successfully, but these errors were encountered: