Skip to content
This repository has been archived by the owner on Jun 4, 2024. It is now read-only.

propagate specific target tags to run and run_shell actions as execution_requirements #190

Merged
merged 1 commit into from
Jun 14, 2019
Merged

propagate specific target tags to run and run_shell actions as execution_requirements #190

merged 1 commit into from
Jun 14, 2019

Conversation

SrodriguezO
Copy link
Collaborator

@SrodriguezO SrodriguezO commented Jun 14, 2019 •
edited
Loading

Resolves #187

@SrodriguezO
Copy link
Collaborator Author

The underlying issue is that tags are not propagated to actions automatically and thus are only applied when the ruleset they're used with propagates them explicitly. This PR handles said propagation for higherkindness/rules_scala.

There is an open PR to bazelbuild/bazel that will handle this propagation on Bazel's side (bazelbuild/bazel#8612), but I wanted the issue to be resolved for highkindness/rules_scala sooner than later. For future consistency, I'm propagating the same tags that PR will propagate.

@SrodriguezO SrodriguezO force-pushed the propagate-tags-from-rules-to-actions branch 2 times, most recently from 35c56fa to c41bc4d Compare June 14, 2019 17:27
@SrodriguezO
Copy link
Collaborator Author

@borkaehw @jjudd would you mind reviewing when you get a min?

@SrodriguezO SrodriguezO force-pushed the propagate-tags-from-rules-to-actions branch from c41bc4d to 97709b8 Compare June 14, 2019 18:54
borkaehw
borkaehw approved these changes Jun 14, 2019
View reviewed changes
Copy link
Collaborator

@borkaehw borkaehw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me. We should revisit it again once Bazel has addressed it (bazelbuild/bazel#8612).

@borkaehw borkaehw merged commit 651fa6b into higherkindness:master Jun 14, 2019
@borkaehw borkaehw deleted the propagate-tags-from-rules-to-actions branch June 14, 2019 20:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JaredNeil JaredNeil JaredNeil left review comments

@borkaehw borkaehw borkaehw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pass select tags from target to generated actions as execution requirements
3 participants
@SrodriguezO @JaredNeil @borkaehw