Skip to content
This repository has been archived by the owner on Jun 4, 2024. It is now read-only.

More tests for deps check #253

Merged
merged 1 commit into from
Dec 16, 2019
Merged

More tests for deps check #253

merged 1 commit into from
Dec 16, 2019

Conversation

borkaehw
Copy link
Collaborator

No description provided.

@borkaehw
Copy link
Collaborator Author

@jjudd I am not sure how to use --define in rules implementation level. But this is how users can make --define working.

SrodriguezO
SrodriguezO approved these changes Dec 16, 2019
View reviewed changes
Copy link
Collaborator

@SrodriguezO SrodriguezO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm; thanks for adding these

@borkaehw borkaehw merged commit ebfaf9b into higherkindness:master Dec 16, 2019
@borkaehw borkaehw deleted the improve-deps-test branch December 16, 2019 18:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@SrodriguezO SrodriguezO SrodriguezO approved these changes

@jjudd jjudd Awaiting requested review from jjudd

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@borkaehw @SrodriguezO