Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(handlebars): add subexpressions, block-params and hash-parameters #2344

Merged
merged 15 commits into from
May 19, 2020
Merged

feat(handlebars): add subexpressions, block-params and hash-parameters #2344

merged 15 commits into from
May 19, 2020

Commits on May 16, 2020

  1. wip: adjustments for integrating handlebars rules 

    - hash-parameters
- subexpressions

wip: adjustments for integrating handlebars rules

- hash-parameters
- subexpressions

wip: update tests

some minor adaptions

wip: fix test cases

wip: try to honor path expressions correctly

wip: fix tests and refactor language definition

wip: update keywords, remove debug output

wip: {{else}} is a keyword and not a helper call

wip: fix test for else-variants

- else is not a built-in (except for the keyword {{else}})

wip: fix hashes and number literals, add string literals

- the hash-value must start after the equals-sign
- number and string modes must be in front of identifiers, because they are a subset

wip: make "as" in block-parameters a "keyword"

fixup: revert tests to old tests from origin/master

fixup: adjust expected test results for failing tests

add else variant tests
    @nknapp
    nknapp committed May 16, 2020
    Configuration menu
    Copy the full SHA
    63acfb1 View commit details
    Browse the repository at this point in the history

  2. fixup: add more tests 

    add else variant tests

fixup
    @nknapp
    nknapp committed May 16, 2020
    Configuration menu
    Copy the full SHA
    a0a5611 View commit details
    Browse the repository at this point in the history

  3. fixup: make only "else" in {{else}} the keywords, not "{{else}}" as w… 

    …hole
    @nknapp
    nknapp committed May 16, 2020
    Configuration menu
    Copy the full SHA
    193f4c2 View commit details
    Browse the repository at this point in the history

  4. add htmlbars back

    @joshgoebel @nknapp
    joshgoebel authored and nknapp committed May 16, 2020
    Configuration menu
    Copy the full SHA
    dc0df11 View commit details
    Browse the repository at this point in the history

  5. (chore) move keyword to sep lines

    @joshgoebel @nknapp
    joshgoebel authored and nknapp committed May 16, 2020
    Configuration menu
    Copy the full SHA
    9c4f581 View commit details
    Browse the repository at this point in the history

  6. (chore) const vs var

    @joshgoebel @nknapp
    joshgoebel authored and nknapp committed May 16, 2020
    Configuration menu
    Copy the full SHA
    cdbd6fd View commit details
    Browse the repository at this point in the history

  7. (chore) linter

    @joshgoebel @nknapp
    joshgoebel authored and nknapp committed May 16, 2020
    Configuration menu
    Copy the full SHA
    88f76a0 View commit details
    Browse the repository at this point in the history

  8. fixup: fix typo in variable name IDENFIFIER_REGEX

    @joshgoebel @nknapp
    joshgoebel authored and nknapp committed May 16, 2020
    Configuration menu
    Copy the full SHA
    74f0c87 View commit details
    Browse the repository at this point in the history

  9. fixup: remove illegal-regex from SUB_EXPRESSION and HASH 

    both never match in a meaningful way.
    @nknapp
    nknapp committed May 16, 2020
    Configuration menu
    Copy the full SHA
    73a1c66 View commit details
    Browse the repository at this point in the history

  10. fixup: remove single and double quotes from HASH_PARAM_REGEX 

    because they are not parsed in hash-keys

both never match in a meaningful way.
    @nknapp
    nknapp committed May 16, 2020
    Configuration menu
    Copy the full SHA
    c0d7faf View commit details
    Browse the repository at this point in the history

  11. fixup: refactor identifier_regex and hash_param_regex

    @nknapp
    nknapp committed May 16, 2020
    Configuration menu
    Copy the full SHA
    9583704 View commit details
    Browse the repository at this point in the history

  12. docs: fix jsdoc-comment to match the actual expected parameter type

    @nknapp
    nknapp committed May 16, 2020
    Configuration menu
    Copy the full SHA
    ad881e4 View commit details
    Browse the repository at this point in the history

  13. fixup: remove unnecessary "keyword"-property

    @nknapp
    nknapp committed May 16, 2020
    Configuration menu
    Copy the full SHA
    803fa5b View commit details
    Browse the repository at this point in the history

Commits on May 19, 2020

  1. chore: add changelog

    @nknapp
    nknapp committed May 19, 2020
    Configuration menu
    Copy the full SHA
    5dc0dd0 View commit details
    Browse the repository at this point in the history

  2. Update CHANGES.md

    @joshgoebel
    joshgoebel authored May 19, 2020
    Configuration menu
    Copy the full SHA
    f664f8f View commit details
    Browse the repository at this point in the history