Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enh(twig): update keywords list #3415

Merged
merged 6 commits into from
Dec 7, 2021

Conversation

MrYamous
Copy link
Contributor

Changes

Update keywords list for Twig according to documentation

Checklist

  • Added markup tests, or they don't apply here because it's about updating keywords list
  • Updated the changelog at CHANGES.md

CHANGES.md Outdated Show resolved Hide resolved
@joshgoebel
Copy link
Member

I've cleaned up the Twig support a lot in my follow-up commit, any chance you could take a look and provide your thoughts?

@joshgoebel
Copy link
Member

Ping.

src/languages/twig.js Outdated Show resolved Hide resolved
@MrYamous
Copy link
Contributor Author

MrYamous commented Dec 7, 2021

I also noticed Symfony's own twig functions and filters are not in the keywords list for the moment (visible in Symfony's doc and Twig's doc)
Do you think it's too specific or can I add them? Maybe with an other PR

@joshgoebel
Copy link
Member

Can one use Twig without Symphony? Def should be a second PR if we go that directly, don't want to slow this one down any further.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants