Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(rust) recognize include_bytes! macro #3541

Merged
merged 1 commit into from
May 23, 2022
Merged

fix(rust) recognize include_bytes! macro #3541

merged 1 commit into from
May 23, 2022

Conversation

Serial-ATA
Copy link
Contributor

@Serial-ATA Serial-ATA commented May 22, 2022 •
edited
Loading

Changes

Change builtin include_bin to include_bytes, as the former doesn't exist.

Checklist

  • Added markup tests, or they don't apply here because it is a simple word correction.
  • Updated the changelog at CHANGES.md

@joshgoebel
Copy link
Member

Was the former deprecated then?

@Serial-ATA
Copy link
Contributor Author

I've never known it to be bin, and bytes has been around since 1.0 so it's probably safe to assume that even if that was the name in the past, no one is using it anymore.

@joshgoebel
Copy link
Member

@Serial-ATA Thanks so much!

@joshgoebel joshgoebel merged commit 4dfb4ae into highlightjs:main May 23, 2022
@YoutacRandS-VA YoutacRandS-VA mentioned this pull request Jun 19, 2024
Open
This was referenced Jul 9, 2024
Open
Open
@VictorPonceSTK VictorPonceSTK mentioned this pull request Jul 28, 2024
Open
@Jimimaku Jimimaku mentioned this pull request Jul 28, 2024
Closed
@Stanislav1975 Stanislav1975 mentioned this pull request Aug 9, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshgoebel joshgoebel joshgoebel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Serial-ATA @joshgoebel