Update Java Language to Java 19 #3641
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add missing Java 19 Keywords * non-sealed as counterpart to sealed * when for when clauses in pattern matching with switch expression * yield for switch expressions
|
Did you test that |
|
Nope not yet. But will! I’ve also forgotten permits as keyword. Will fix and Test this on Monday.
________________________________
Von: ffontecha080 ***@***.***>
Gesendet: Saturday, October 22, 2022 5:51:14 PM
An: highlightjs/highlight.js ***@***.***>
Cc: Merlin Bögershausen ***@***.***>; Author ***@***.***>
Betreff: Re: [highlightjs/highlight.js] Update Java Language to Java 19 (PR #3641)
@ffontecha080 approved this pull request.
________________________________
In src/languages/java.js<#3641 (comment)>:
@@ -72,7 +72,10 @@ export default function(hljs) {
'requires',
'exports',
'do',
export
—
Reply to this email directly, view it on GitHub<#3641 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABZVCFJJEJCMW23HOBRMGJ3WEQEPFANCNFSM6AAAAAARKJ4CNA>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
TBH non-sealed already was part of hightlight.js prio. I'll did a in depth analysis (see linked Tickets). Should we close ad forget this one and start with clear new PRs? |
Whatever is easiest for you... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
add missing Java 19 Keywords
Checklist
CHANGES.md