-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to new styles #911
Update to new styles #911
Conversation
Sannis
commented
Aug 18, 2015
- fortran
- irpf90
- golo
- kotlin
- nsis
- step21
- tp
aa76efc
to
e2a8d2d
Compare
@isagalaev you can merge this at any moment - I'll just create new branch for next bunch of languages. |
Yes, I should be able to look into this today! |
I've got one general comment. I still haven't made my mind about calling built-in types by the "type" class name. This was intended for languages like Haskell and Scala where a type is an important concept and they are mostly user-defined, rather than being just built-in primitive types. So in languages like Java I just stick those with the other keywords. If this explanation does make sense, let's keep it this way for now. Also kotlin.js has many things called "type" (like stuff between |
I used to work on such tasks iteratively, so I set a goal to reduce CSS classes number. |
…into new-styles-sannis-1
@isagalaev what about |
The difference between keywords and literals is quite clear: keywords define code structure, literals are just special values, along with numbers and strings. As long as the description is clear I prefer to keep things separate as it is always possible to just color them the same way if needed. |
@isagalaev, I've merged built-in types into keywords for these languages. |
Nice! |
Only three left now :-) And a bunch of other stuff (docs, cleanup, etc.) |