Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Download Allow List Process #138

Merged
merged 3 commits into from
Oct 27, 2020
Merged

Download Allow List Process #138

merged 3 commits into from
Oct 27, 2020

Conversation

hhund
Copy link
Member

@hhund hhund commented Oct 26, 2020

Adds process to download and update the allow list from a known server via a full Bundle url.
Renames remaining occurrences of "whitelist" into "allow list"

closes #118

@hhund hhund added this to the v0.3.0 milestone Oct 26, 2020
@hhund hhund requested a review from wetret October 26, 2020 17:23
@hhund hhund linked an issue Oct 26, 2020 that may be closed by this pull request
Copy link
Member

@wetret wetret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently you need to know the bundle URL to be able to download the allow list. It would also be nice if you could only specify the TTP where the BPE should look for the bundle. After that, a search for the latest version will be executed and if there is a bundle, it will be downloaded.

@hhund
Copy link
Member Author

hhund commented Oct 27, 2020

I implemented it intentionally a little bit inconvenient. I think we should add support for BPMN user tasks to enable reviewing a downloaded transaction bundle before executing it. I added #139 to track supporting user tasks and #140, #141 and #142 to modify the existing resource "download" processes.

@hhund hhund merged commit 25d1563 into develop Oct 27, 2020
@hhund hhund deleted the issues/118_download_allow_list branch November 3, 2020 15:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add process to manually download the allow list
2 participants