Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid error message logged during execution #429

Closed
MarkARussell opened this issue Oct 5, 2023 · 12 comments · Fixed by #430
Closed

Invalid error message logged during execution #429

MarkARussell opened this issue Oct 5, 2023 · 12 comments · Fixed by #430
Assignees
Labels
Milestone

Comments

@MarkARussell
Copy link

The latest 3.0.1 version of the jaxb-maven-plugin logs an invalid/incorrect error message to the console during execution. Specifically I see the message [ERROR] Could not find JAXB 2.x API classes. Make sure JAXB 2.x API is on the classpath.

It looks like maven-plugin/plugin-core/src/main/java/org/jvnet/jaxb/maven/AbstractXJCMojo.java code still contains some string versions of the old javax.xml.bind packages which the code uses in an attempt to instantiate the classes. The strings are used in the logApiConfiguration() function of the AbstractXJCMojo class.

The constants I think still needing updating:

  • XML_SCHEMA_CLASS_QNAME
  • XML_SCHEMA_RESOURCE_QNAME
  • XML_ELEMENT_REF_CLASS_QNAME

The logApiConfiguration function may need some rework as well since it's attempting to resolve the JAXB version for logging purposes.

@mattrpav mattrpav added this to the 4.0.0 milestone Oct 6, 2023
@mattrpav
Copy link
Collaborator

mattrpav commented Oct 6, 2023

Holding off on releasing v4.0.0 until we look at this one. We might need a new v3.x as well

@laurentschoelens
Copy link
Collaborator

@mattrpav PR provided for master

@laurentschoelens
Copy link
Collaborator

Hi @MarkARussell

@mattrpav just released v4 and available : https://central.sonatype.com/artifact/org.jvnet.jaxb/jaxb-maven-plugin/4.0.0

If you are not stuck with jaxb 3 api or jdk8 support, could you give it a try ?

V3.0.2 with backported fix will be available in a few days.

Thanks
Laurent

@MarkARussell
Copy link
Author

Yep trialed the 4.0.0 version this morning and working perfectly. Thanks for such a fast turn-around

@laurentschoelens
Copy link
Collaborator

Yep trialed the 4.0.0 version this morning and working perfectly. Thanks for such a fast turn-around

Many thanks to you for reporting this to us.
If you found other issues, feel free to open other issue here, we'll be glad to see what we could do to help 😀

@OLibutzki
Copy link

V3.0.2 with backported fix will be available in a few days.

Do you still plan to release 3.0.2?

@laurentschoelens
Copy link
Collaborator

Yes but we need to work on multi release pipeline
@mattrpav should be the most appropriate person to give an update on this one.
@OLibutzki : by curiosity, you need jakarta AND jdk8 ?

@OLibutzki
Copy link

@OLibutzki : by curiosity, you need jakarta AND jdk8 ?

Unfortunately, yes... but I have to admit that this is certainly quite unusual.

@laurentschoelens
Copy link
Collaborator

laurentschoelens commented Jan 5, 2024

Yes and jaxb3 is not quite supported too.
In any case, we'll do the 3.0.2 release too as planned 👍 But with not as many bugfixes as in 4.0.1 or 2.0.10

@mattrpav
Copy link
Collaborator

mattrpav commented Jan 5, 2024

JAXB 4 requires JDK 11.

ref: https://jakarta.ee/specifications/xml-binding/4.0/

mattrpav pushed a commit to mattrpav/jaxb-tools that referenced this issue Feb 5, 2024
@laurentschoelens
Copy link
Collaborator

laurentschoelens commented Aug 29, 2024

Yes and jaxb3 is not quite supported too. In any case, we'll do the 3.0.2 release too as planned 👍 But with not as many bugfixes as in 4.0.1 or 2.0.10

@OLibutzki : 3.0.2 has been released (sorry for the delay 😄), enjoy !

Full 3.0.2 release note here

@OLibutzki
Copy link

Thanks, I've been waiting every day. 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants