Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to javaparser 3.x #529

Closed
winfriedgerlach opened this issue Mar 25, 2024 · 12 comments · Fixed by #530
Closed

Switch to javaparser 3.x #529

winfriedgerlach opened this issue Mar 25, 2024 · 12 comments · Fixed by #530
Assignees
Labels
dependencies Pull requests that update a dependency file enhancement

Comments

@winfriedgerlach
Copy link

This project uses com.google.code.javaparser:javaparser:1.0.11. This release is now 10 years old (02/2014) and the project is meanwhile dead and replaced by a fork, https://github.com/javaparser/javaparser

Also, the old library used has LGPL license only while the fork is available under both LGPL and Apache license, which may better suit commercial users.

It would be great if you could make the switch to com.github.javaparser:javaparser-core:3.x.x.

@laurentschoelens
Copy link
Collaborator

Hi @winfriedgerlach :
I've already tried to move to javaparser 3.x but it was a bit complicated from that time.
I'll try to give a look at this now that everything as been merged here

@laurentschoelens
Copy link
Collaborator

If also you want, you can also provide PR 😄

@winfriedgerlach
Copy link
Author

winfriedgerlach commented Mar 26, 2024

@laurentschoelens I did start a PR but noticed quickly the same as you: Some changes are not trivial and unfortunately if have zero prior knowledge regarding javaparser, so it's quite likely I would break something...

@laurentschoelens
Copy link
Collaborator

No problem, I'll give it a look after next 4.x release 😉

@laurentschoelens laurentschoelens self-assigned this Mar 27, 2024
@laurentschoelens laurentschoelens added enhancement dependencies Pull requests that update a dependency file labels Mar 27, 2024
@laurentschoelens
Copy link
Collaborator

I'll commit move to latest javaparser 2.x which is easier and do not introduce to much breaking change. Then move to javaparser 3.x with incremental version number. Is it OK for you to have 2.x first ?

@winfriedgerlach
Copy link
Author

@laurentschoelens If that works for you, great! I like incremental, smaller updates.

@laurentschoelens
Copy link
Collaborator

Note on upgrading to v3 : https://javaparser.org/2-5-1-to-3-0-0-migration-guide/

laurentschoelens added a commit to laurentschoelens/jaxb-tools that referenced this issue Mar 27, 2024
…11 to com.github.javaparser:javaparser-core:2.5.1
@laurentschoelens
Copy link
Collaborator

Created : #530

@laurentschoelens
Copy link
Collaborator

Move to javaparser 3 is locked by javaparser/javaparser#4355

@winfriedgerlach
Copy link
Author

@laurentschoelens thanks so much for putting in the effort!

laurentschoelens added a commit to laurentschoelens/jaxb-tools that referenced this issue Mar 29, 2024
laurentschoelens added a commit to laurentschoelens/jaxb-tools that referenced this issue Mar 29, 2024
laurentschoelens added a commit to laurentschoelens/jaxb-tools that referenced this issue Mar 29, 2024
laurentschoelens added a commit to laurentschoelens/jaxb-tools that referenced this issue Mar 29, 2024
@laurentschoelens
Copy link
Collaborator

@winfriedgerlach : managed to fix the v3.x migration blocking error. Build is OK with 3.0.1. Will try to move to latest 3.x now

laurentschoelens added a commit to laurentschoelens/jaxb-tools that referenced this issue Mar 29, 2024
@winfriedgerlach
Copy link
Author

@laurentschoelens wow, great progress! Thanks again for your effort!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants