-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to javaparser 3.x #529
Comments
Hi @winfriedgerlach : |
If also you want, you can also provide PR 😄 |
@laurentschoelens I did start a PR but noticed quickly the same as you: Some changes are not trivial and unfortunately if have zero prior knowledge regarding javaparser, so it's quite likely I would break something... |
No problem, I'll give it a look after next 4.x release 😉 |
I'll commit move to latest javaparser 2.x which is easier and do not introduce to much breaking change. Then move to javaparser 3.x with incremental version number. Is it OK for you to have 2.x first ? |
@laurentschoelens If that works for you, great! I like incremental, smaller updates. |
Note on upgrading to v3 : https://javaparser.org/2-5-1-to-3-0-0-migration-guide/ |
…11 to com.github.javaparser:javaparser-core:2.5.1
Created : #530 |
Move to javaparser 3 is locked by javaparser/javaparser#4355 |
@laurentschoelens thanks so much for putting in the effort! |
@winfriedgerlach : managed to fix the v3.x migration blocking error. Build is OK with 3.0.1. Will try to move to latest 3.x now |
@laurentschoelens wow, great progress! Thanks again for your effort! |
…github.javaparser:javaparser-core:2.5.1
…github.javaparser:javaparser-core:2.5.1
…github.javaparser:javaparser-core:2.5.1
This project uses
com.google.code.javaparser:javaparser:1.0.11
. This release is now 10 years old (02/2014) and the project is meanwhile dead and replaced by a fork, https://github.com/javaparser/javaparserAlso, the old library used has LGPL license only while the fork is available under both LGPL and Apache license, which may better suit commercial users.
It would be great if you could make the switch to
com.github.javaparser:javaparser-core:3.x.x
.The text was updated successfully, but these errors were encountered: