Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Needs update to latest commons-lang3 & commons-text #540

Closed
davija opened this issue Jun 5, 2024 · 9 comments · Fixed by #542
Closed

Needs update to latest commons-lang3 & commons-text #540

davija opened this issue Jun 5, 2024 · 9 comments · Fixed by #542
Assignees
Labels
bug dependencies Pull requests that update a dependency file enhancement
Milestone

Comments

@davija
Copy link

davija commented Jun 5, 2024

Version 4.0.6 of jaxb-maven-plugin & jaxb-plugin-annotate rely on a method that has been deprecated and running with any version later 3.12.0 breaks.

This is in:
org.apache.commons.text.translate.NumericEntityEscaper.between (NumericEntityEscaper.java:59)
image

Please update to use the latest commons-lang3 & commons-text libraries.

@davija
Copy link
Author

davija commented Jun 5, 2024

Digging through the code it appears this is related to usage of StringEscapeUtils from org.apache.commons.text.StringEscapeUtils

@mattrpav
Copy link
Collaborator

mattrpav commented Jun 6, 2024

Our usage of commons-* is pretty minimal. We may look to remove it altogether and either use more modern JDK built-in functions or self-host a few of the utilities that are used.

@davija
Copy link
Author

davija commented Jun 6, 2024

That would be nice, but in the mean time we need something that works with newer versions as we have dependencies which require newer versions. When we use the newer versions, this plugin pukes.

@laurentschoelens
Copy link
Collaborator

laurentschoelens commented Jun 6, 2024

@davija thanks for the report
@mattrpav : outside of plugin's usage, it would be nice to drop some dependencies

@laurentschoelens
Copy link
Collaborator

The #542 PR fixes the issue here by removing the unwanted / conflicted dependencies.

@laurentschoelens
Copy link
Collaborator

@davija feel free to look at the PR

@davija
Copy link
Author

davija commented Jun 6, 2024

@laurentschoelens I looked at it this morning and it should resolve my issue so I closed my PR in favor of this one.

@laurentschoelens
Copy link
Collaborator

@davija 4.0.7 just been released and should be available in maven central soon

@laurentschoelens
Copy link
Collaborator

You can also go for 4.0.8 which includes another fix (for another unrelated issue)

Regards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug dependencies Pull requests that update a dependency file enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants