Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JT-176 : Bump plexus-utils / plexus-build-api #281

Merged
merged 1 commit into from
Aug 8, 2023
Merged

JT-176 : Bump plexus-utils / plexus-build-api #281

merged 1 commit into from
Aug 8, 2023

Conversation

laurentschoelens
Copy link
Collaborator

@laurentschoelens laurentschoelens commented Aug 2, 2023 •
edited
Loading

See : #176

@laurentschoelens
Copy link
Collaborator Author

Same as #249 but with higher version and migration of plexus-build-api from sonatype:0.0.7 to codehaus:1.2.0

@laurentschoelens laurentschoelens force-pushed the jt-176 branch 2 times, most recently from ae9815c to ff70c8a Compare August 4, 2023 15:24
@laurentschoelens laurentschoelens changed the title Bump plexus-utils / plexus-build-api JT-176 : Bump plexus-utils / plexus-build-api Aug 4, 2023
@mattrpav mattrpav self-assigned this Aug 8, 2023
@mattrpav mattrpav added this to the 2.0.4 milestone Aug 8, 2023
mattrpav
mattrpav requested changes Aug 8, 2023
View reviewed changes
Copy link
Collaborator

@mattrpav mattrpav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please refactor to put a property for the version number(s), and then update the dependency using the macro ${ .. }

<plexus-build-api.version>1.2.0</plexus-build-api.version>
<plexus-utils.version>3.5.1</plexus-utils.version>

@laurentschoelens
Copy link
Collaborator Author

Please refactor to put a property for the version number(s), and then update the dependency using the macro ${ .. }

<plexus-build-api.version>1.2.0</plexus-build-api.version> <plexus-utils.version>3.5.1</plexus-utils.version>

  • Changed applied
  • Force push done

mattrpav
mattrpav approved these changes Aug 8, 2023
View reviewed changes
Copy link
Collaborator

@mattrpav mattrpav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mattrpav mattrpav merged commit a071b68 into highsource:master Aug 8, 2023
@laurentschoelens laurentschoelens mentioned this pull request Aug 9, 2023
Closed
@laurentschoelens laurentschoelens deleted the jt-176 branch September 12, 2023 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattrpav mattrpav mattrpav approved these changes

Assignees

@mattrpav mattrpav

Labels
None yet
Projects
None yet
Milestone
2.0.4
Development

Successfully merging this pull request may close these issues.
2 participants
@laurentschoelens @mattrpav