Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing issue JT-194 : adding TypeArtifactFilter to exclude pom artifacts #288

Merged
merged 1 commit into from
Aug 14, 2023

Conversation

laurentschoelens
Copy link
Collaborator

This will exclude pom artifacts in collectBindingUrisFromDependencies and so, fix #194

@laurentschoelens
Copy link
Collaborator Author

Adding UT to validate provided / not jar filtered artifacts.
Change in function signature to make it package visible from test class.

@mattrpav
Copy link
Collaborator

mattrpav commented Aug 8, 2023

Do we have a maven project test to confirm this works outside the unit test?

@mattrpav mattrpav added this to the 2.0.4 milestone Aug 8, 2023
@mattrpav mattrpav self-assigned this Aug 8, 2023
@laurentschoelens
Copy link
Collaborator Author

I can add one 😄

Copy link
Collaborator

@mattrpav mattrpav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't 'scanDependenciesForBindings' be enabled in the plugin config to verify?

@laurentschoelens
Copy link
Collaborator Author

  • Rebased PR from master since conflicts with latest merge

  • Adding scanDependenciesForBindings flag to true

  • Tested with 2.0.2 version of the plugin and get the following error :

[ERROR] Failed to execute goal org.jvnet.jaxb:jaxb-maven-plugin:2.0.2:generate (generate) on project jaxb-maven-plugin-tests-194: Unable to read the artifact JAR file [.../.m2/repository/org/apache/commons/commons-lang3/3.12.0/commons-lang3-3.12.0.pom].: zip END header not found -> [Help 1]
  • Tested with 2.0.4-SNAPSHOT current version, build is OK

For me, this simple jt-194 test project validate the fix

@mattrpav
Copy link
Collaborator

#299 has follow-on task to validate the 'scanDependenciesForBindings' feature going forward

Copy link
Collaborator

@mattrpav mattrpav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mattrpav mattrpav merged commit 47738a3 into highsource:master Aug 14, 2023
@laurentschoelens laurentschoelens deleted the jt-194 branch August 25, 2023 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

scanDependenciesForBindings fails on dependency of type pom
2 participants