-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing issue JT-194 : adding TypeArtifactFilter to exclude pom artifacts #288
Conversation
ceefa1d
to
e10e667
Compare
Adding UT to validate provided / not jar filtered artifacts. |
Do we have a maven project test to confirm this works outside the unit test? |
I can add one 😄 |
e10e667
to
7a406a4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't 'scanDependenciesForBindings' be enabled in the plugin config to verify?
7a406a4
to
73ec4b2
Compare
For me, this simple |
#299 has follow-on task to validate the 'scanDependenciesForBindings' feature going forward |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This will exclude pom artifacts in collectBindingUrisFromDependencies and so, fix #194