Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update README #368

Merged
merged 1 commit into from
Sep 11, 2023
Merged

update README #368

merged 1 commit into from
Sep 11, 2023

Conversation

soc
Copy link
Contributor

@soc soc commented Sep 11, 2023

  • replace outdated links
  • drop obsolete parts
  • adjust wording
  • add information on v3

@soc soc force-pushed the patch-1 branch 2 times, most recently from 86b17b5 to 4d0a393 Compare September 11, 2023 09:23
@laurentschoelens
Copy link
Collaborator

@soc thanks for your contribution.

Could you adapt with the following changes ?

Thanks

@laurentschoelens laurentschoelens self-assigned this Sep 11, 2023
@laurentschoelens laurentschoelens added the documentation Adding or updating documentation label Sep 11, 2023
@soc
Copy link
Contributor Author

soc commented Sep 11, 2023

I would point to new location of jaxb-api / jaxb-ri github places

I feared it would be confusing to link to v3 resources while the plugin only supports v2, but will do!

I wouldn't remove the note about mojohaus maven-plugin

I dropped it because I figured if we can't explain what it is and how it differs from this project, then it will not be helpful to readers either.
Do you have some additional info we can add there?

@laurentschoelens
Copy link
Collaborator

I would point to new location of jaxb-api / jaxb-ri github places

I feared it would be confusing to link to v3 resources while the plugin only supports v2, but will do!

There's no active branches for jaxb-api v2 / v3 but the latest release are in the new location (https://github.com/jakartaee/jaxb-api/tree/2.3.3)
For jaxb-ri, the EE8 branch points to jaxb-api v2.3.3.

I wouldn't remove the note about mojohaus maven-plugin

I dropped it because I figured if we can't explain what it is and how it differs from this project, then it will not be helpful to readers either. Do you have some additional info we can add there?

Since the names or now quite identical, pointing to mojohaus' plugin would help user create the issue in the right location in my opinion.

- replace outdated links
- drop obsolete parts
- adjust wording
- add information on v3
@soc
Copy link
Contributor Author

soc commented Sep 11, 2023

Pushed some changes, moved the link to JAXB to the top to avoid having two links right next to each other, better this way?

@laurentschoelens
Copy link
Collaborator

LGTM, I'll let @mattrpav validate before merging :)

Copy link
Collaborator

@laurentschoelens laurentschoelens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

Copy link
Collaborator

@mattrpav mattrpav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mattrpav mattrpav merged commit 657c5f4 into highsource:master Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Adding or updating documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants