[#438] get version of XJC at runtime and dump it on source generation #440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattrpav
requested changes
Oct 12, 2023
| * @return currently running XJC version | ||
| */ | ||
| public XJCVersion getVersion() { | ||
| return XJCVersion.empty(); |
There was a problem hiding this comment.
How about we make this a XJCVersion.NOT_DETECTED; <-- static string?
There was a problem hiding this comment.
Will define static instance UNDEFINED
| package org.jvnet.jaxb.maven; | ||
|
|
||
| public class XJCVersion { | ||
| private String raw = "N/A"; |
There was a problem hiding this comment.
Perhaps add a public static final String NOT_DETECTED = "NOT DETECTED" <-- as a way to signal to users that there is a tooling version mismatch?
There was a problem hiding this comment.
method isKnown will return true if at least one version (major, minor, bugfix) is > 0
| } | ||
| } | ||
|
|
||
| public static XJCVersion empty() { |
There was a problem hiding this comment.
don't love this.. seems like a static constant could work instead?
laurentschoelens
force-pushed
the
jt-438
branch
from
fa8f394 to
34377b7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #438