Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Refactor the configuration mechanism used by SDK #285

Merged
merged 3 commits into from
Feb 20, 2024

Conversation

CH3CHO
Copy link
Collaborator

@CH3CHO CH3CHO commented Jan 20, 2024

Ⅰ. Describe what this PR did

Refactor the configuration mechanism used by SDK.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@CH3CHO CH3CHO requested a review from johnlanni January 20, 2024 12:30
@CH3CHO CH3CHO marked this pull request as draft January 22, 2024 01:14
@CH3CHO CH3CHO force-pushed the feat/sdk-config branch 2 times, most recently from 09d4fa7 to bd1f20b Compare January 24, 2024 02:44
@CH3CHO CH3CHO marked this pull request as ready for review January 24, 2024 02:46
Copy link
Contributor

@johnlanni johnlanni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@johnlanni johnlanni merged commit 056686d into higress-group:main Feb 20, 2024
4 checks passed
@CH3CHO CH3CHO deleted the feat/sdk-config branch February 20, 2024 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants