Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support configuring HTTPS certificate for the default domain #297

Merged
merged 1 commit into from
Mar 3, 2024

Conversation

CH3CHO
Copy link
Collaborator

@CH3CHO CH3CHO commented Mar 2, 2024

Ⅰ. Describe what this PR did

Support configuring HTTPS certificate for the default domain.

image

image

image

Ⅱ. Does this pull request fix one issue?

fixes #292

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Copy link
Contributor

@johnlanni johnlanni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@johnlanni johnlanni merged commit b389e17 into higress-group:main Mar 3, 2024
4 checks passed
@CH3CHO CH3CHO deleted the feat/default-https-cert branch March 3, 2024 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

https代理时,允许配置domain为*,以适配单域名模式业务
2 participants