Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Not to overwrite any existed configurations in Nacos during initialization #50

Merged
merged 1 commit into from
Dec 25, 2023

Conversation

CH3CHO
Copy link
Collaborator

@CH3CHO CH3CHO commented Dec 23, 2023

just in case user installs a second Higress instance to the same Nacos server and namespace.

publishConfig() {
  # $1 namespace
  # $2 configType: plural
  # $3 configName
  # $4 content
  # $5 skipWhenExisted
  case $CONFIG_STORAGE in
    nacos)
      publishNacosConfig "$@"
      ;;
    file)
      publishFileConfig "$@"
      ;;
    *)
      printf "  Unknown storage type: %s\n" "$CONFIG_STORAGE"
      exit -1
      ;;
  esac
}

Copy link
Contributor

@johnlanni johnlanni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@johnlanni johnlanni merged commit 0c1e4c1 into higress-group:main Dec 25, 2023
2 checks passed
@CH3CHO CH3CHO deleted the fix/over-install branch December 25, 2023 08:11
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants