Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support ArrayBufferView as BufferLike #176

Closed
jon-chuang opened this issue Mar 17, 2023 · 1 comment
Closed

Support ArrayBufferView as BufferLike #176

jon-chuang opened this issue Mar 17, 2023 · 1 comment
Assignees
@hildjj

Comments

@jon-chuang
Copy link

jon-chuang commented Mar 17, 2023 •
edited
Loading

Typescript:

Argument of type 'ArrayBufferView' is not assignable to parameter of type 'BufferLike'.
@hildjj hildjj self-assigned this Mar 18, 2023
@hildjj
Copy link
Owner

hildjj commented Mar 18, 2023

There was some reason I didn't do this the first time through, but I don't remember it at the moment. This is a completely reasonable request.

hildjj added a commit that referenced this issue May 15, 2023
@hildjj
Support ArrayBufferView as BufferLike. Fixes #176.
344feb0
@hildjj hildjj closed this as completed in 4a9d507 Oct 25, 2024
hildjj added a commit that referenced this issue Oct 25, 2024
@hildjj
Merge pull request #203 from hildjj/fix-176
3f27076 
Allow any ArrayBufferView in decode.  Fixes #176
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hildjj hildjj

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hildjj @jon-chuang