chore: Make sure all targets in workspace been covered by clippy (apa…

…che#702) Signed-off-by: Xuanwo <github@xuanwo.io>
himadripal · Jul 22, 2024 · f1bf797 · f1bf797
1 parent 4de1adc
commit f1bf797
Show file tree

Hide file tree

Showing 4 changed files with 31 additions and 27 deletions.
diff --git a/.github/actions/rust-test/action.yaml b/.github/actions/rust-test/action.yaml
@@ -29,7 +29,7 @@ runs:
       shell: bash
       run: |
         cd native
-        cargo clippy --color=never -- -D warnings
+        cargo clippy --color=never --all-targets --workspace -- -D warnings
 
     - name: Check compilation
       shell: bash

diff --git a/native/core/src/execution/datafusion/expressions/xxhash64.rs b/native/core/src/execution/datafusion/expressions/xxhash64.rs
@@ -181,7 +181,10 @@ mod test {
         let hash2 = spark_compatible_xxhash64(data, seed);
         if hash1 != hash2 {
             panic!("input: {} with seed {seed} produced incorrect hash (comet={hash2}, twox-hash={hash1})",
-                   data.iter().map(|byte| format!("{:02x}", byte)).collect::<String>())
+                   data.iter().fold(String::new(), |mut output, byte| {
+                       output.push_str(&format!("{:02x}", byte));
+                       output
+                   }))
         }
     }
 }
diff --git a/native/core/src/execution/datafusion/planner.rs b/native/core/src/execution/datafusion/planner.rs
@@ -2060,29 +2060,31 @@ mod tests {
         type_id: i32,
         lit: spark_expression::Literal,
     ) -> spark_operator::Operator {
-        let mut expr = spark_expression::Expr::default();
+        let left = spark_expression::Expr {
+            expr_struct: Some(Bound(spark_expression::BoundReference {
+                index: 0,
+                datatype: Some(spark_expression::DataType {
+                    type_id,
+                    type_info: None,
+                }),
+            })),
+        };
+        let right = spark_expression::Expr {
+            expr_struct: Some(Literal(lit)),
+        };
 
-        let mut left = spark_expression::Expr::default();
-        left.expr_struct = Some(Bound(spark_expression::BoundReference {
-            index: 0,
-            datatype: Some(spark_expression::DataType {
-                type_id,
-                type_info: None,
-            }),
-        }));
-        let mut right = spark_expression::Expr::default();
-        right.expr_struct = Some(Literal(lit));
-
-        expr.expr_struct = Some(Eq(Box::new(spark_expression::Equal {
-            left: Some(Box::new(left)),
-            right: Some(Box::new(right)),
-        })));
-
-        let mut op = spark_operator::Operator::default();
-        op.children = vec![child_op];
-        op.op_struct = Some(OpStruct::Filter(spark_operator::Filter {
-            predicate: Some(expr),
-        }));
-        op
+        let expr = spark_expression::Expr {
+            expr_struct: Some(Eq(Box::new(spark_expression::Equal {
+                left: Some(Box::new(left)),
+                right: Some(Box::new(right)),
+            }))),
+        };
+
+        Operator {
+            children: vec![child_op],
+            op_struct: Some(OpStruct::Filter(spark_operator::Filter {
+                predicate: Some(expr),
+            })),
+        }
     }
 }
diff --git a/native/core/src/execution/datafusion/shuffle_writer.rs b/native/core/src/execution/datafusion/shuffle_writer.rs
@@ -1461,8 +1461,7 @@ mod test {
         let array = b.finish();
         let batch = RecordBatch::try_new(schema.clone(), vec![Arc::new(array)]).unwrap();
 
-        let mut batches = Vec::new();
-        batches.push(batch.clone());
+        let batches = vec![batch.clone()];
 
         let partitions = &[batches];
         let exec = ShuffleWriterExec::try_new(