-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BOT PROFILE: Quick UI Tweaks #1411
Comments
For styling emoji issue, we may have to schedule rn upgrade (2 months old). This issue could be fixed by latest update. |
@bengtan: I was writing notes during our meeting, I'm not as thorough. The usage of 'may' and 'could' means speculation.
|
estimate is for the first 3 items. The emoji thing is a big can of unknown. |
should the bottom border on the header be there for all screens or just this one? |
@southerneer for now, all bot headers (including map view), @irfirl and I haven't appropriately reviewed it for all of the headers on the app...for all screens we'd have a separate ticket where we properly review all the headers in the app |
@zavreb @mstidham @irfirl codepushed to Staging-Eric. This includes the channges from Pavel's codepush on his channel. @zavreb changing the navbar bottom border across the whole app is easy. Changing piecemeal per screen would take some time. Let's wait until you guys have looked over the whole thing to keep from wasting dev time. For now I've added the light gray border across the whole app. It's easy to remove if we don't want it in the meantime. |
Codepush Staging-Eric Verified |
Codepush Staging-Eric Verified. |
Verified on Staging |
1 similar comment
Verified on Staging |
Verified on Staging 1.56.3 |
Verified on Prod |
1 similar comment
Verified on Prod |
Verified on Prod. Closing ticket. |
Report
option red (we understand only one option can be red)Save/Edit
andShare
icons are at equal widths, the current implementation shows the Save CTA larger than the Share icon... maintain existing UI for private botsReport text should be red in action sheet
Line for header
Emoji breaks styling for header
The text was updated successfully, but these errors were encountered: