Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BOT PROFILE: Quick UI Tweaks #1411

Closed
4 tasks done
zavreb opened this issue Oct 16, 2017 · 15 comments
Closed
4 tasks done

BOT PROFILE: Quick UI Tweaks #1411

zavreb opened this issue Oct 16, 2017 · 15 comments
Assignees

Comments

@zavreb
Copy link

zavreb commented Oct 16, 2017

  • Please make the Report option red (we understand only one option can be red)
  • See here for zeplin link: zpl.io/aM0vmzV
  • Please ensure the Save/Edit and Share icons are at equal widths, the current implementation shows the Save CTA larger than the Share icon... maintain existing UI for private bots
  • Please enable the line at the bottom of the header for separation of UI purposes (see here for example: zpl.io/2GvOQJb)
  • When user enters emoji first for a Bot Title, the header loses its styling, an emoji as the first entry should not let this happen, please fix (if it's a difficult fix, we can push to separate ticket)

Report text should be red in action sheet

image

Line for header

image

Emoji breaks styling for header

image

@zavreb
Copy link
Author

zavreb commented Oct 17, 2017

For styling emoji issue, we may have to schedule rn upgrade (2 months old). This issue could be fixed by latest update.

@bengtan
Copy link
Contributor

bengtan commented Oct 17, 2017

@zavreb:

For styling emoji issue, we may have to schedule rn upgrade (2 months old). This issue could be fixed by latest update.

Uh, you're jumping the gun here. This was just speculation by @aksonov. Let him (or someone) look into the emoji issue first.

@zavreb
Copy link
Author

zavreb commented Oct 18, 2017

@bengtan: I was writing notes during our meeting, I'm not as thorough. The usage of 'may' and 'could' means speculation.

For styling emoji issue, we may have to schedule rn upgrade (2 months old). This issue could be fixed by latest update.

@southerneer
Copy link
Contributor

estimate is for the first 3 items. The emoji thing is a big can of unknown.

@southerneer
Copy link
Contributor

should the bottom border on the header be there for all screens or just this one?

southerneer pushed a commit that referenced this issue Oct 24, 2017
@zavreb
Copy link
Author

zavreb commented Oct 24, 2017

@southerneer for now, all bot headers (including map view), @irfirl and I haven't appropriately reviewed it for all of the headers on the app...for all screens we'd have a separate ticket where we properly review all the headers in the app

@southerneer
Copy link
Contributor

@zavreb @mstidham @irfirl codepushed to Staging-Eric. This includes the channges from Pavel's codepush on his channel.

@zavreb changing the navbar bottom border across the whole app is easy. Changing piecemeal per screen would take some time. Let's wait until you guys have looked over the whole thing to keep from wasting dev time. For now I've added the light gray border across the whole app. It's easy to remove if we don't want it in the meantime.

@mstidham
Copy link

Codepush Staging-Eric Verified

@zavreb
Copy link
Author

zavreb commented Oct 25, 2017

Codepush Staging-Eric Verified.

@mstidham
Copy link

Verified on Staging

1 similar comment
@irfirl
Copy link
Contributor

irfirl commented Oct 27, 2017

Verified on Staging

@zavreb
Copy link
Author

zavreb commented Oct 27, 2017

Verified on Staging 1.56.3

@mstidham
Copy link

mstidham commented Nov 1, 2017

Verified on Prod

1 similar comment
@irfirl
Copy link
Contributor

irfirl commented Nov 1, 2017

Verified on Prod

@zavreb
Copy link
Author

zavreb commented Nov 1, 2017

Verified on Prod. Closing ticket.

@zavreb zavreb closed this as completed Nov 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants