Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

for #4849 #4875

Merged
merged 2 commits into from
Mar 5, 2020
Merged

for #4849 #4875

merged 2 commits into from
Mar 5, 2020

Conversation

aksonov
Copy link
Contributor

@aksonov aksonov commented Mar 5, 2020

No description provided.

@aksonov aksonov requested a review from southerneer March 5, 2020 16:46
southerneer
southerneer approved these changes Mar 5, 2020
View reviewed changes
Copy link
Contributor

@southerneer southerneer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a fine stop-gap solution but we should still pursue a general solution for the problem of persisting values locally.

@southerneer southerneer merged commit 0435a39 into master Mar 5, 2020
@southerneer southerneer deleted the 4849 branch March 5, 2020 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@southerneer southerneer southerneer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aksonov @southerneer