fix: use classTarget when updating manager too #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seems like the moment you import any `storybook-dark-mode` into the preview side of things, `updateManager` is causes the body tag to have the classname put on it.
if we specific
```tsx
export const parameters = {
darkMode: {
classTarget: 'html'
},
};
```
Seems to me that what we really want is that only the `html` tag be manipulated.
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #174
seems like the moment you import any
storybook-dark-modeinto the preview side of things,updateManageris causes the body tag to have the classname put on it.if we specify
Seems to me that what we really want is that only the
htmltag be manipulated.