Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow to set multiple image names with delimiter for ignore_tag_images #40

Conversation

mski-iksm
Copy link
Contributor

@mski-iksm mski-iksm commented Apr 1, 2024

There are some cases that we want to set multiple values for image names.

How ever we can only set multiple image names in following:

--ignore-tag-images image_name_1 --ignore-tag-images image_name_2

It is much easier if we can set in following format, because writing format can be shared regardless of number of images.

--ignore-tag-images image_name_1,image_name_2

@mski-iksm
Copy link
Contributor Author

@hirosassa @kitagry Please review!

Copy link
Contributor

@kitagry kitagry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.74%. Comparing base (53b7216) to head (3257ab2).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #40      +/-   ##
==========================================
- Coverage   71.37%   70.74%   -0.64%     
==========================================
  Files           7        7              
  Lines         758      728      -30     
==========================================
- Hits          541      515      -26     
+ Misses        217      213       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@hirosassa hirosassa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for your first contribution.

@hirosassa hirosassa merged commit b954a74 into hirosassa:main Apr 1, 2024
5 of 6 checks passed
@hirosassa
Copy link
Owner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants