-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separate change kinds #41
Conversation
c9d665d
to
dea6a17
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Cargo.toml
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
src/template.rs
Outdated
{{#if (gt (len created_kinds) 0)}} | ||
* created | ||
{{#each created_kinds}} | ||
* {{this}} | ||
{{/each}} | ||
{{/if}} | ||
{{#if (gt (len pruned_kinds) 0)}} | ||
* pruned | ||
{{#each pruned_kinds}} | ||
* {{this}} | ||
{{/each}} | ||
{{/if}} | ||
{{#if (gt (len configured_kinds) 0)}} | ||
* configured | ||
{{#each configured_kinds}} | ||
* {{this}} | ||
{{/each}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[comment] @kitagry
Did you consider using H2 (or smaller one) as a separator?
If not, I think it is good to compare the format.
{{#if (gt (len created_kinds) 0)}} | |
* created | |
{{#each created_kinds}} | |
* {{this}} | |
{{/each}} | |
{{/if}} | |
{{#if (gt (len pruned_kinds) 0)}} | |
* pruned | |
{{#each pruned_kinds}} | |
* {{this}} | |
{{/each}} | |
{{/if}} | |
{{#if (gt (len configured_kinds) 0)}} | |
* configured | |
{{#each configured_kinds}} | |
* {{this}} | |
{{/each}} | |
{{#if (gt (len created_kinds) 0)}} | |
## created | |
{{#each created_kinds}} | |
* {{this}} | |
{{/each}} | |
{{/if}} | |
{{#if (gt (len pruned_kinds) 0)}} | |
## pruned | |
{{#each pruned_kinds}} | |
* {{this}} | |
{{/each}} | |
{{/if}} | |
{{#if (gt (len configured_kinds) 0)}} | |
## configured | |
{{#each configured_kinds}} | |
* {{this}} | |
{{/each}} |
d6c280a
to
77498db
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #41 +/- ##
==========================================
+ Coverage 70.74% 74.37% +3.63%
==========================================
Files 7 7
Lines 728 804 +76
==========================================
+ Hits 515 598 +83
+ Misses 213 206 -7 ☔ View full report in Codecov by Sentry. |
I fixed! |
@kitagry Thanks! |
before
after